Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more warehouses to database permissions #3943

Merged
merged 52 commits into from
Nov 1, 2023
Merged

Add more warehouses to database permissions #3943

merged 52 commits into from
Nov 1, 2023

Conversation

agnessnowplow
Copy link
Contributor

@agnessnowplow agnessnowplow commented Aug 17, 2023 •
edited by mirnawong1
Loading

What are you changing in this pull request and why?

The proposed changes are regarding this issue raised last week: #3901

It would be nice to have more warehouses within References / warehouse permissions with sample grants, this PR aims to follow the already existing Snowflake example and add Databricks, Redshift, and Postgres as well (skipping BigQuery due to their unique IAM access control management)

#Resolves #3824

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js

  • Provide a unique filename for the new page

  • Needs to have a technical review, at least to verify the proposed changes are correct and possibly expand with other examples.

  • Tested it locally (npm run)

@agnessnowplow agnessnowplow requested a review from a team as a code owner August 17, 2023 15:39
@welcome
Copy link

welcome bot commented Aug 17, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@netlify
Copy link

netlify bot commented Aug 17, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit ea1fab2
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64ef1197e3411300085d9a44
😎 Deploy Preview https://deploy-preview-3943--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content size: medium This change will take up to a week to address labels Aug 17, 2023
@rlh1994
Copy link
Contributor

rlh1994 commented Sep 25, 2023

Hey @mirnawong1 is there anything we need to change to be able to get this merged please?

@vercel
Copy link

vercel bot commented Sep 25, 2023

@mirnawong1 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@mirnawong1
Copy link
Contributor

this is so great @agnessnowplow and @rlh1994 ! thanks so much for opening this up and providing such diligent and detailed contributions 😍 ! apologies for the delay here and I'll review this right now - am going to loop in @dataders as well for his technical help - thank you for flagging @rlh1994 !

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Nov 1, 2023 6:21pm

@mirnawong1
Update snowflake-permissions.md
03ddf3e 
adding discourse article to resolves issue dbt-labs#3824
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Nov 1, 2023
mirnawong1
mirnawong1 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @agnessnowplow and @rlh1994 ! i think we're at a good place now and the deploy preview looks pretty great! i really appreciate you opening this wonderful pr and flagging this for us - this page needed some attention and thanks to your contribution, it now has much more info.

I'll get this merged for you but let me know if you have any questions or concerns

@mirnawong1 mirnawong1 merged commit 5422e9a into dbt-labs:current Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlh1994 rlh1994 rlh1994 left review comments

@dataders dataders dataders left review comments

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide more context to Snowflake Permissions page
5 participants
@agnessnowplow @rlh1994 @mirnawong1 @dataders @runleonarun